Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(dropdown): style improvements #786

Merged
merged 6 commits into from
Jan 30, 2019
Merged

fix(dropdown): style improvements #786

merged 6 commits into from
Jan 30, 2019

Conversation

bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented Jan 29, 2019 •
edited
Loading

fix(dropdown): style improvements

This PR covers the following improvements on Dropdown component styles:

  • add scroll in the selected items box (see GIF below)
  • corner rounding on listbox
  • remove weird rounding on the border bottom of the compose box input
  • add shadow around listbox
  • set and expose maxHeight variables for selected items box and listbox

Sreenshots:

Scrolling behavior:

screen recording 2019-01-30 at 14 49 03

Before:

screenshot 2019-01-29 at 15 15 37

After:

screenshot 2019-01-29 at 15 15 50

Known issues:

Technical limitation for setting maxHeight on the listbox (list of results), see #560 (comment)

Later edit:

  1. Fixed maxHeight issue - accessibility needs to be tested
  2. Accessibility tested and looks fine

@bmdalex bmdalex self-assigned this Jan 29, 2019
silviuaavram
silviuaavram approved these changes Jan 29, 2019
View reviewed changes
Copy link
Collaborator

@silviuaavram silviuaavram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small comment

@bmdalex bmdalex force-pushed the fix/dropdown-style-improvements branch 4 times, most recently from cb5cbd8 to f1e752a Compare January 30, 2019 14:22
@bmdalex bmdalex force-pushed the fix/dropdown-style-improvements branch from a72b7a4 to a41057a Compare January 30, 2019 17:00
@bmdalex bmdalex mentioned this pull request Jan 30, 2019
Closed
@bmdalex bmdalex merged commit 733169b into master Jan 30, 2019
@bmdalex bmdalex deleted the fix/dropdown-style-improvements branch January 30, 2019 17:17
@silviuaavram silviuaavram mentioned this pull request Apr 1, 2019
Closed
21 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miroslavstastny miroslavstastny miroslavstastny left review comments

@silviuaavram silviuaavram silviuaavram approved these changes

@layershifter layershifter layershifter approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@kuzhelov kuzhelov Awaiting requested review from kuzhelov

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees

@bmdalex bmdalex

Labels
🚀 ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmdalex @miroslavstastny @silviuaavram @layershifter