Skip to content

Make sure negative date periods are correctly handled. #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 8, 2024

Conversation

SilasKenneth
Copy link
Member

@SilasKenneth SilasKenneth commented Apr 29, 2024

@SilasKenneth SilasKenneth requested a review from a team as a code owner April 29, 2024 13:09
@SilasKenneth SilasKenneth self-assigned this Apr 29, 2024
@baywet
Copy link
Member

baywet commented Apr 29, 2024

@SilasKenneth what issue is this addressing?

@SilasKenneth
Copy link
Member Author

SilasKenneth commented Apr 29, 2024

Hi @baywet , The description is updated with the issue.
microsoftgraph/msgraph-sdk-php#1504

@SilasKenneth
Copy link
Member Author

SilasKenneth commented Apr 30, 2024

Hi @shemogumbe , kindly spare some time to review the PR relating to this on the Abstractions repo. These changes are going to be removed from this package once the abstraction PR is merged.
Here

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet baywet requested a review from shemogumbe May 2, 2024 13:26
Copy link

sonarqubecloud bot commented May 2, 2024

@SilasKenneth SilasKenneth dismissed shemogumbe’s stale review May 3, 2024 16:01

Moved the changes to abstractions

@SilasKenneth SilasKenneth merged commit 46dbfcd into dev May 8, 2024
@SilasKenneth SilasKenneth deleted the fix/negative-intervals branch May 8, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Migrating from 1.96 to 2.4 booking service issue
3 participants