Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into the behavior of
*
in VS Code’s glob implementation and found that it actually matches zero or more characters in a path segment—not one or more as LSP 3.17 states. Specifically:In the VS Code source (glob.ts), the comment reads “
*
to match zero or more characters in a path segment.”The “Glob Patterns” documentation on code.visualstudio.com also says “zero or more.”
Inspecting the implementation:
In regex syntax,
*
means “zero or more” of the preceding pattern, and the?
makes it non-greedy.So it looks like LSP 3.17’s description of
*
is simply a typo.