fix: exit script as failure if methods are missing

mxschmitt · mxschmitt · commit d26ae22b72cb · 2020-09-03T16:58:23.000+02:00
diff --git a/scripts/documentation_provider.py b/scripts/documentation_provider.py
@@ -43,6 +43,29 @@
     },
 }
 
+allowed_missing_methods = [
+    "Download.createReadStream",
+    "Browser.startTracing",
+    "Browser.stopTracing",
+    "Logger.log",
+    "BrowserContext.setHTTPCredentials",  # deprecated
+    "BrowserContext.serviceWorkers",  # CR only (and the following)
+    "BrowserContext.backgroundPages",
+    "Browser.newBrowserCDPSession",
+    "Page.coverage",
+    "Coverage.startCSSCoverage",
+    "Coverage.stopCSSCoverage",
+    "Coverage.startJSCoverage",
+    "Coverage.stopJSCoverage",
+    "BrowserContext.newCDPSession",
+    "Logger.isEnabled",
+    "BrowserServer.kill",  # not relevant for RPC clients (and the following)
+    "BrowserType.launchServer",
+    "BrowserServer.close",
+    "BrowserServer.process",
+    "BrowserServer.wsEndpoint",
+]
+
 
 class DocumentationProvider:
     def __init__(self) -> None:
@@ -380,10 +403,15 @@ def print_remainder(self) -> None:
                 if method["kind"] == "event":
                     continue
                 entry = f"{class_name}.{method_name}"
-                if entry not in self.printed_entries:
+                if (
+                    entry not in self.printed_entries
+                    and entry not in allowed_missing_methods
+                ):
                     remainders.add(f"Method not implemented: {entry}")
         for remainder in remainders:
             print(remainder, file=stderr)
+        if len(remainders) > 0:
+            exit(1)
 
 
 if __name__ == "__main__":
