Fix: Playwright fails if you suppress stderr (#1098) #1100

AlberLC · 2022-01-12T21:27:41Z

No description provided.

mxschmitt · 2022-01-13T09:53:51Z

Hello, thank you for your contribution! I think it would be better to check if the stderr is closed, and if so, return None. Something like that:

        if sys.stderr.closed:
            return None

This should lead to the same behaviour but is more explicit.

Fix: Playwright fails if you suppress stderr (microsoft#1098)

c8118f9

Fix: Check if stderr is closed (microsoft#1098)

eb26372

mxschmitt approved these changes Jan 13, 2022

View reviewed changes

mxschmitt merged commit c16481b into microsoft:main Jan 13, 2022

Provide feedback