Skip to content

chore: provide driver with the host-lang version #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2022
Merged

chore: provide driver with the host-lang version #1107

merged 2 commits into from
Jan 18, 2022

Conversation

mxschmitt
Copy link
Member

Fixes #1103

aslushnikov
aslushnikov approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % test that the default user agent indeed includes Python + version (see Java for the test example - microsoft/playwright-java#774)

@mxschmitt mxschmitt force-pushed the driver-version branch 2 times, most recently from 824711b to 4935382 Compare January 18, 2022 17:10
@mxschmitt mxschmitt merged commit 4e1113c into microsoft:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

internal: setup env variables when launching driver
2 participants
@mxschmitt @aslushnikov