Skip to content

chore: minor cleanup for coverage #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2020
Merged

chore: minor cleanup for coverage #115

merged 2 commits into from
Jul 31, 2020

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Jul 31, 2020 •
edited
Loading

By default, Python uses utf-8 encoding.

Fixed also in the web server the unclosed file handlers.

@coveralls
Copy link

coveralls commented Jul 31, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 190457905

  • 19 of 25 (76.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 88.121%
Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/network.py 2 3 66.67%
playwright/page.py 11 16 68.75%
Files with Coverage Reduction New Missed Lines %
playwright/page.py 2 89.39%
Totals Coverage Status
Change from base Build 189393918: 0.07%
Covered Lines: 3301
Relevant Lines: 3746
💛 - Coveralls

pavelfeldman
pavelfeldman reviewed Jul 31, 2020
View reviewed changes
@pavelfeldman pavelfeldman merged commit c36ccc4 into microsoft:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxschmitt @coveralls @pavelfeldman