Skip to content

feat(expect): add expect_navigation, expect_load_state, navigation tests #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2020
Merged

feat(expect): add expect_navigation, expect_load_state, navigation tests #118

merged 1 commit into from
Aug 1, 2020

Conversation

pavelfeldman
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Aug 1, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 190962862

  • 124 of 183 (67.76%) changed or added relevant lines in 13 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 87.986%
Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/browser_context.py 0 2 0.0%
playwright/frame.py 19 21 90.48%
playwright/event_context_manager.py 3 9 33.33%
playwright/async_api.py 17 31 54.84%
playwright/page.py 30 44 68.18%
playwright/sync_api.py 10 31 32.26%
Files with Coverage Reduction New Missed Lines %
playwright/connection.py 1 97.62%
playwright/event_context_manager.py 2 52.38%
Totals Coverage Status
Change from base Build 190494037: -0.1%
Covered Lines: 3347
Relevant Lines: 3804
💛 - Coveralls

@pavelfeldman pavelfeldman force-pushed the expect_navigation branch 2 times, most recently from 058a735 to 0b078e9 Compare August 1, 2020 06:06
@pavelfeldman pavelfeldman merged commit 875b380 into microsoft:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelfeldman @coveralls