test: fix Docker tests #1274
Merged
test: fix Docker tests #1274
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fa1d1f to
825ee5c
Compare
825ee5c to
004cc2f
Compare
dgozman
approved these changes
Apr 27, 2022
| @@ -36,6 +36,8 @@ jobs: | |||
| - name: Test | |||
| run: | | |||
| CONTAINER_ID="$(docker run --rm -v $(pwd):/root/playwright --name playwright-docker-test --workdir /root/playwright/ -d -t playwright-python:localbuild-focal /bin/bash)" | |||
| # Fix permissions for Git inside the container | |||
| docker exec "${CONTAINER_ID}" chown -R root:root /root/playwright | |||
There was a problem hiding this comment.
Do we have the same issue in production docker images?
There was a problem hiding this comment.
no, this is only because we mount a Git repository (outside) which was created by the GitHub Actions user inside the container. And Python (setuptools) internally does use Git to determine which version tag it uses internally, this failed before. The Git error message above was added very recently to Git as well, thats why it was working a few weeks ago and now not anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/root/playwrightinside the Docker container is owned by1001:121(runner:docker) which is !=root:rootthats why we get the following error message:The folder was created by the checkout action from GitHub Actions, which uses the GitHub Action default user for that.
Relates to git/git@8959555
cc/FYI @dscho