Skip to content

fix(connect): when using a large payload #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2022
Merged

fix(connect): when using a large payload #1351

merged 1 commit into from
Jun 8, 2022

Conversation

mxschmitt
Copy link
Member

Fixes #1350

Relates #1177

@mxschmitt mxschmitt force-pushed the fix-websocket-large-payload branch from 02fb88a to b437cbc Compare June 8, 2022 09:44
@mxschmitt mxschmitt marked this pull request as ready for review June 8, 2022 09:44
@mxschmitt mxschmitt requested a review from rwoll June 8, 2022 09:45
rwoll
rwoll approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@rwoll rwoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you anticipate any perf changes?

@mxschmitt
Copy link
Member Author

LGTM! Do you anticipate any perf changes?

its aligned now the same as we have upstream. So probably better for larger payloads.

@mxschmitt mxschmitt merged commit b23a29c into microsoft:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rwoll rwoll rwoll approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: playwright._impl._api_types.Error: Playwright connection closed
2 participants
@mxschmitt @rwoll