chore: rework apiName api call handling in connection #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2da0a0a to
2619980
Compare
2619980 to
2008ece
Compare
2008ece to
0e136ae
Compare
pavelfeldman
approved these changes
Jun 21, 2022
playwright/_impl/_connection.py
Outdated
| ) | ||
|
|
||
| def send_no_reply(self, method: str, params: Dict = None) -> None: | ||
| self._connection.wrap_api_call_sync( |
There was a problem hiding this comment.
Why do we need a separate method for this?
playwright/_impl/_connection.py
Outdated
| await cast(Coroutine, result) if asyncio.iscoroutine(result) else result | ||
| ) | ||
| task = asyncio.current_task(self._loop) | ||
| st: List[inspect.FrameInfo] = getattr(task, "__pw_stack__", inspect.stack()) |
There was a problem hiding this comment.
This assumes there were no async hops on the way from API call to wrap_api_call. I believe this is the case, but I'm not sure we should rely upon in. Consider leaving _async wrapper in place as a safer option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1220