Skip to content

feat: added Download.saveAs(path) #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

mxschmitt
Copy link
Member

Relates #144

@mxschmitt mxschmitt force-pushed the feature/download-saveAs branch from 742ee18 to f358f53 Compare August 5, 2020 18:55
@rwoll
Copy link
Member

rwoll commented Aug 5, 2020

Based on the failures, it looks like we may need to roll to a later playwright (JS) version here since we updated saveAs create missing directory behavior in microsoft/playwright#3249.

@mxschmitt
Copy link
Member Author

Based on the failures, it looks like we may need to roll to a later playwright (JS) version here since we updated saveAs create missing directory behavior in microsoft/playwright#3249.

thx will do 👍

@mxschmitt mxschmitt force-pushed the feature/download-saveAs branch from f358f53 to 79fdec6 Compare August 5, 2020 22:09
@github-actions
Copy link

github-actions bot commented Aug 5, 2020

Pull Request Test Coverage Report for Build 196865794

  • 8 of 9 (88.89%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 89.529%

Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/sync_api.py 1 2 50.0%
Totals Coverage Status
Change from base Build 196864489: -0.004%
Covered Lines: 3651
Relevant Lines: 4078

💛 - Coveralls

@mxschmitt mxschmitt merged commit ef38e91 into microsoft:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants