Skip to content

chore(build): have allow-list in setup.py included packages #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2022
Merged

chore(build): have allow-list in setup.py included packages #1510

merged 2 commits into from
Aug 18, 2022

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Aug 17, 2022 •
edited
Loading

Before it was the following:

>>> find_packages(exclude=["tests*"])
['playwright', 'playwright._impl', 'playwright.async_api', 'playwright.sync_api', 'playwright._impl.__pyinstaller']

after reducing it to the shown in the PR, it was still fine with my local integration tests (build wheel, install from wheel).

Fixes #1504.

rwoll
rwoll approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@rwoll rwoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisional LGTM. Please diff site directory before and after this change to esnsure the whole distributed/installed file hierarchy is identical before v. after.

@mxschmitt mxschmitt merged commit 2d922d2 into microsoft:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rwoll rwoll rwoll approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[internal] move to inlcude, instead of exclude for setup.py
2 participants
@mxschmitt @rwoll