chore: roll to Playwright ToT #1576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Oct 5, 2022
| @@ -46,6 +47,9 @@ async def register( | |||
| await channel._channel.send("register", params) | |||
| self._registrations.append(params) | |||
|
|
|||
| def set_test_id_attribute(self, attribute_name: str) -> None: | |||
| set_test_id_attribute_name(attribute_name) | |||
There was a problem hiding this comment.
Suggested change
| set_test_id_attribute_name(attribute_name) | |
| Locator.set_test_id_attribute_name(attribute_name) |
and inside Locators class:
@staticmethod
def set_test_id_attribute_name(date):
...Try to align it as much as possible to upstream when it's easy to do, this helps for maintenance.
There was a problem hiding this comment.
I'll align from the other side!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.