feat: roll driver to 1.3.0-next.1596843106133, handle paths on the client side #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 200030402Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
pavelfeldman
approved these changes
Aug 8, 2020
mxschmitt
approved these changes
Aug 8, 2020
pavelfeldman
reviewed
Aug 8, 2020
| @@ -57,7 +57,7 @@ async def test_context_cookies_should_work(server, launch_persistent): | |||
| "expires": -1, | |||
| "httpOnly": False, | |||
| "secure": False, | |||
| "sameSite": "None", | |||
| "sameSite": "Lax" if is_firefox else "None", | |||
There was a problem hiding this comment.
Andrey says that Firefox has switched the defaults.
There was a problem hiding this comment.
"There is currently no timeline to ship this feature to the release channel of Firefox.". Let's make sure to fix it upstream. Filing a bug
|
We might need to update client then to ensure proper 🍪 roundtrip. |
pavelfeldman
approved these changes
Aug 9, 2020
|
Should we postpone this until upstream is fixed? |
Pavel was fine with it (via Slack). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.