Skip to content

fix: remove duplicated keyword argument timeout #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 21, 2023
Merged

fix: remove duplicated keyword argument timeout #1870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
265ae21
fix: mark `Playwright.stop` async
m9810223 Apr 14, 2023
419f1c3
Merge branch 'microsoft:main' into main
m9810223 Apr 20, 2023
d6ec2f4
fix: remove duplicated keyword argument `timeout`
m9810223 Apr 20, 2023
3f5bd63
fix: remove duplicated keyword argument `timeout`
m9810223 Apr 21, 2023
72d6a14
test: test `timeout` for `Locator`
m9810223 Apr 21, 2023
3a56a42
simplify it
mxschmitt Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions playwright/_impl/_locator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ async def evaluate_handle(
self, expression: str, arg: Serializable = None, timeout: float = None
) -> "JSHandle":
return await self._with_element(
lambda h, o: h.evaluate_handle(expression, arg), timeout
lambda h, _: h.evaluate_handle(expression, arg), timeout
)

async def fill(
Expand Down Expand Up @@ -518,7 +518,9 @@ async def screenshot(
) -> bytes:
params = locals_to_params(locals())
return await self._with_element(
lambda h, timeout: h.screenshot(timeout=timeout, **params)
lambda h, timeout: h.screenshot(
**{**params, "timeout": timeout}, # type: ignore
),
)

async def scroll_into_view_if_needed(
Expand Down Expand Up @@ -550,7 +552,7 @@ async def select_option(
async def select_text(self, force: bool = None, timeout: float = None) -> None:
params = locals_to_params(locals())
return await self._with_element(
lambda h, timeout: h.select_text(timeout=timeout, **params), timeout
lambda h, timeout: h.select_text(**{**params, "timeout": timeout}), timeout # type: ignore
)

async def set_input_files(
Expand Down
4 changes: 4 additions & 0 deletions tests/sync/test_locators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ def test_locators_should_select_textarea(
textarea = page.locator("textarea")
textarea.evaluate("textarea => textarea.value = 'some value'")
textarea.select_text()
textarea.select_text(timeout=1_000)
if browser_name == "firefox" or browser_name == "webkit":
assert textarea.evaluate("el => el.selectionStart") == 0
assert textarea.evaluate("el => el.selectionEnd") == 10
Expand All @@ -381,6 +382,9 @@ def test_locators_should_screenshot(
page.evaluate("window.scrollBy(50, 100)")
element = page.locator(".box:nth-of-type(3)")
assert_to_be_golden(element.screenshot(), "screenshot-element-bounding-box.png")
assert_to_be_golden(
element.screenshot(timeout=1_000), "screenshot-element-bounding-box.png"
)


def test_locators_should_return_bounding_box(page: Page, server: Server) -> None:
Expand Down