Skip to content

fix(context): allow defaultBrowserType keyword #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2020
Merged

fix(context): allow defaultBrowserType keyword #196

merged 1 commit into from
Sep 25, 2020

Conversation

mxschmitt
Copy link
Member

Fixes #195

pavelfeldman
pavelfeldman reviewed Sep 25, 2020
View reviewed changes
playwright/async_api.py Outdated
@@ -5364,6 +5364,7 @@ async def newContext(
hasTouch: bool = None,
colorScheme: Literal["light", "dark", "no-preference"] = None,
acceptDownloads: bool = None,
defaultBrowserType: typing.Any = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah better 👍

@mxschmitt mxschmitt closed this Sep 25, 2020
@mxschmitt mxschmitt force-pushed the bugfix/device-descriptors-spread branch from 5e3282f to 542c3a7 Compare September 25, 2020 20:54
@mxschmitt mxschmitt reopened this Sep 25, 2020
@mxschmitt mxschmitt merged commit 63d302c into microsoft:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] newPage() got an unexpected keyword argument 'defaultBrowserType'
2 participants
@mxschmitt @pavelfeldman