-
Notifications
You must be signed in to change notification settings - Fork 1k
devops: added Docker image #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1a29e81
devops: added Docker image
mxschmitt fbba6da
fix: review comments
mxschmitt 0f757ee
test to fix bots
mxschmitt 641eed2
fix: failing unit test
mxschmitt 289b38f
Merge branch 'master' of https://github.com/microsoft/playwright-pyth…
mxschmitt 15ce6e2
fix: it
mxschmitt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
!/dist/playwright*manylinux1*.whl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
name: Test Docker | ||
on: | ||
push: | ||
paths: | ||
- '.github/workflows/test_docker.yml' | ||
- 'driver/**' | ||
branches: | ||
- master | ||
pull_request: | ||
paths: | ||
- '.github/workflows/test_docker.yml' | ||
- 'driver/**' | ||
branches: | ||
- master | ||
jobs: | ||
build: | ||
timeout-minutes: 60 | ||
runs-on: ubuntu-20.04 | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Node.js | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: 12.x | ||
- name: Set up Python | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: 3.8 | ||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install -r local-requirements.txt | ||
pip install -e . | ||
- name: Build package | ||
run: python build_package.py | ||
- name: Install | ||
run: python -m playwright install | ||
- name: Build Docker image | ||
run: docker build -t playwright-python:localbuild . | ||
- name: Test | ||
run: | | ||
CONTAINER_ID="$(docker run --rm -v $(pwd):/root/playwright --name playwright-docker-test -d -t playwright-python:localbuild /bin/bash)" | ||
docker exec --workdir /root/playwright/ "${CONTAINER_ID}" pip install -r local-requirements.txt | ||
docker exec --workdir /root/playwright/ "${CONTAINER_ID}" pip install -e . | ||
docker exec --workdir /root/playwright/ "${CONTAINER_ID}" xvfb-run pytest -vv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
FROM ubuntu:focal | ||
|
||
# 1. Install latest Python | ||
RUN apt-get update && apt-get install -y python3 python3-pip && \ | ||
update-alternatives --install /usr/bin/pip pip /usr/bin/pip3 1 && \ | ||
update-alternatives --install /usr/bin/python python /usr/bin/python3 1 | ||
|
||
# 2. Install WebKit dependencies | ||
RUN apt-get update && DEBIAN_FRONTEND="noninteractive" apt-get install -y --no-install-recommends \ | ||
libwoff1 \ | ||
libopus0 \ | ||
libwebp6 \ | ||
libwebpdemux2 \ | ||
libenchant1c2a \ | ||
libgudev-1.0-0 \ | ||
libsecret-1-0 \ | ||
libhyphen0 \ | ||
libgdk-pixbuf2.0-0 \ | ||
libegl1 \ | ||
libnotify4 \ | ||
libxslt1.1 \ | ||
libevent-2.1-7 \ | ||
libgles2 \ | ||
libxcomposite1 \ | ||
libatk1.0-0 \ | ||
libatk-bridge2.0-0 \ | ||
libepoxy0 \ | ||
libgtk-3-0 \ | ||
libharfbuzz-icu0 | ||
|
||
# 3. Install gstreamer and plugins to support video playback in WebKit. | ||
RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
libgstreamer-gl1.0-0 \ | ||
libgstreamer-plugins-bad1.0-0 \ | ||
gstreamer1.0-plugins-good \ | ||
gstreamer1.0-libav | ||
|
||
# 4. Install Chromium dependencies | ||
RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
libnss3 \ | ||
libxss1 \ | ||
libasound2 \ | ||
fonts-noto-color-emoji \ | ||
libxtst6 | ||
|
||
# 5. Install Firefox dependencies | ||
RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
libdbus-glib-1-2 \ | ||
libxt6 | ||
|
||
# 6. Install ffmpeg to bring in audio and video codecs necessary for playing videos in Firefox. | ||
RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
ffmpeg | ||
|
||
# 7. (Optional) Install XVFB if there's a need to run browsers in headful mode | ||
RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
xvfb | ||
|
||
# 8. Feature-parity with node.js base images. | ||
RUN apt-get update && apt-get install -y --no-install-recommends git ssh | ||
|
||
# 9. Create the pwuser (we internally create a symlink for the pwuser and the root user) | ||
RUN adduser pwuser | ||
|
||
# === BAKE BROWSERS INTO IMAGE === | ||
|
||
# 1. Add tip-of-tree Playwright Python package to install its browsers. | ||
# The package should be built beforehand from tip-of-tree Playwright. | ||
COPY ./dist/playwright*manylinux1*.whl /tmp/playwright-1.0-py3-none-manylinux1_x86_64.whl | ||
|
||
# 2. Install playwright and then delete the installation. | ||
# Browsers will remain downloaded in `/home/pwuser/.cache/ms-playwright`. | ||
RUN su pwuser -c "mkdir /tmp/pw && cd /tmp/pw && \ | ||
pip install /tmp/playwright-1.0-py3-none-manylinux1_x86_64.whl && \ | ||
python -m playwright install" && \ | ||
rm -rf /tmp/pw && rm /tmp/playwright-1.0-py3-none-manylinux1_x86_64.whl | ||
|
||
# 3. Symlink downloaded browsers for root user | ||
RUN mkdir /root/.cache/ && \ | ||
ln -s /home/pwuser/.cache/ms-playwright/ /root/.cache/ms-playwright |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.