Skip to content

fix #2215 (NameError in /_impl/frame.py) #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2023
Merged

fix #2215 (NameError in /_impl/frame.py) #2216

merged 1 commit into from
Dec 30, 2023

Conversation

obaltian
Copy link
Contributor

This bad cast() was introduced either in 1.39.0 or 1.40.0 (probably 1.40.0) - 1.38.0 works.
Fixes #2215.

@mxschmitt mxschmitt merged commit cb3a24e into microsoft:main Dec 30, 2023
@mxschmitt
Copy link
Member

Thank you!

@obaltian obaltian deleted the patch-1 branch December 30, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] NameError: name 'Page' is not defined (bad use of typing.cast() in playwright)
2 participants
@obaltian @mxschmitt