Skip to content

test: fix stalling future #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2024
Merged

test: fix stalling future #2282

merged 1 commit into from
Feb 9, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Feb 9, 2024 •
edited
Loading

This fixes:

Task was destroyed but it is pending!
task: <Task pending name='Task-26888' coro=<Page._on_route() running at /root/playwright/playwright/_impl/_page.py:253> wait_for=<Task pending name='Task-26889' coro=<test_page_close_does_not_wait_for_active_route_handlers.<locals>._handler2() running at /root/playwright/tests/async/test_unroute_behavior.py:368> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0xffff6dc6dbb0>()]> cb=[<TaskWakeupMethWrapper object at 0xffff6dc4fb20>()]> cb=[AsyncIOEventEmitter._emit_run.<locals>.callback() at /usr/local/lib/python3.8/dist-packages/pyee/asyncio.py:69]>
Task was destroyed but it is pending!
task: <Task pending name='Task-26889' coro=<test_page_close_does_not_wait_for_active_route_handlers.<locals>._handler2() running at /root/playwright/tests/async/test_unroute_behavior.py:368> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0xffff6dc6dbb0>()]> cb=[<TaskWakeupMethWrapper object at 0xffff6dc4fb20>()]>

@mxschmitt mxschmitt merged commit 752467d into microsoft:main Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mxschmitt