fix: datetime parsing with non-UTC timezones #2322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b40b669 to
a67c336
Compare
2967a13 to
5c8d201
Compare
5c8d201 to
0e65fb7
Compare
eddec2b to
aaa2bf2
Compare
aaa2bf2 to
3879299
Compare
yury-s
approved these changes
Mar 12, 2024
| @@ -205,7 +210,10 @@ def parse_value(value: Any, refs: Optional[Dict[int, Any]] = None) -> Any: | |||
| return a | |||
|
|
|||
| if "d" in value: | |||
| return datetime.fromisoformat(value["d"][:-1]) | |||
| # Node.js Date objects are always in UTC. | |||
| return datetime.datetime.strptime( | |||
There was a problem hiding this comment.
It's unfortunate that we send an iso string over the wire, parsing millis since epoch (with datetime.fromtimestamp) would be more straightforward. But that's a big change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: This makes datetime with non-UTC timezone objects