Skip to content

fix(connect): Future exception was never retrieved on close() #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2024
Merged

fix(connect): Future exception was never retrieved on close() #2427

merged 1 commit into from
May 2, 2024

Conversation

mxschmitt
Copy link
Member

Fixes #2426

Mirror of:

playwright-python/playwright/_impl/_connection.py

Lines 371 to 374 in 5b64618

# No reply messages are used to e.g. waitForEventInfo(after) which returns exceptions on page close.
# To prevent 'Future exception was never retrieved' we just ignore such messages.
if callback.no_reply:
return

@mxschmitt mxschmitt force-pushed the fix-connect-close-promise branch from 892abc7 to 75d3afe Compare May 2, 2024 11:13
@mxschmitt mxschmitt changed the title fix(connect): Future exception was never retrieved with connect fix(connect): Future exception was never retrieved on close() May 2, 2024
@mxschmitt mxschmitt merged commit cb94c25 into microsoft:main May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Future finished exception=TargetClosedError('Target page, context or browser has been closed')
2 participants
@mxschmitt @yury-s