Skip to content

chore: remove api.json and use it from driver #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

chore: remove api.json and use it from driver #288

merged 1 commit into from
Nov 12, 2020

Conversation

mxschmitt
Copy link
Member

Closes #278

@mxschmitt mxschmitt force-pushed the enh/remove-api-json branch from df2c53d to bd5d4fb Compare November 8, 2020 21:26
@mxschmitt mxschmitt force-pushed the enh/remove-api-json branch from bd5d4fb to fb83059 Compare November 8, 2020 21:30
@mxschmitt mxschmitt requested a review from yury-s November 12, 2020 08:25
yury-s
yury-s reviewed Nov 12, 2020
View reviewed changes
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that api.json is not stored in the repo there is no way to tell what version of playwright was used to generated python APIs. Let's include playwright-cli version into *_apy.py when generating APIs?

@mxschmitt
Copy link
Member Author

Now that api.json is not stored in the repo there is no way to tell what version of playwright was used to generated python APIs. Let's include playwright-cli version into *_apy.py when generating APIs?

On the bots (GitHub Actions) we ensure that the generated script output is equal with the HEAD, so you can never make changes and forget to generate. By that we always know that the previous HEAD sync/async generated output was the generated with the version of the HEAD, in my mind its fine, or wdyt?

yury-s
yury-s approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good enough then.

@yury-s yury-s merged commit fe413f0 into microsoft:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

@pavelfeldman pavelfeldman Awaiting requested review from pavelfeldman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove api.json and use it from the driver as subprocess call
2 participants
@mxschmitt @yury-s