fix: screenshot Errors if path without file extension is provided with specifying type #2966
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 3, 2025 21:48
…path does not include extension.
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2965
If a path without a file type extension is provided without passing the file type arg to
screenshot, it will throw an Error that you provided an invalid mimetype (None).This causes the
--screenshotcommand line arg in theplaywright-pytestplugin to no longer work, as it passes a path without an extension.Documentation on playwright.dev and the docstrings state the default screenshot file type should be PNG, this PR will default to PNG if type or a file extension in path are not provided.