Skip to content

fix: Use urllib instead of curl #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix: Use urllib instead of curl #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build_package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import stat
import subprocess
import sys
import urllib.request
import zipfile

from playwright.path_utils import get_file_dirname
Expand All @@ -40,7 +41,7 @@ def driver_version(platform: str) -> str:
if not os.path.exists("driver/" + zip_file):
url = "https://playwright.azureedge.net/builds/cli/next/" + zip_file
print("Fetching ", url)
subprocess.check_call(["curl", url, "-o", "driver/" + zip_file])
urllib.request.urlretrieve(url, "driver/" + zip_file)

_dirname = get_file_dirname()
_build_dir = _dirname / "build"
Expand Down