chore: roll Playwright to 0.170.0-next.1605573954344 #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Nov 17, 2020
mxschmitt
approved these changes
Nov 17, 2020
756ea0b to
2d81187
Compare
2d81187 to
7e74000
Compare
mxschmitt
reviewed
Nov 18, 2020
| method: str | ||
| headers: List[Header] | ||
| postData: str | ||
| url: Optional[str] |
There was a problem hiding this comment.
since total=False all keys inside the dict are optional, so afaik you don't have to specify it each time.
There was a problem hiding this comment.
I'd like to treat it as a type, probably total=False should not be there
There was a problem hiding this comment.
I think mypy then complains from the user perspective if you only specify a single property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.