Skip to content

fix: don't set attr on bound method #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2021
Merged

fix: don't set attr on bound method #539

merged 1 commit into from
Mar 2, 2021

Conversation

pavelfeldman
Copy link
Member

Fixes #538

@pavelfeldman pavelfeldman merged commit 436132c into microsoft:master Mar 2, 2021
pavelfeldman added a commit that referenced this pull request Mar 2, 2021
@pavelfeldman
fix: don't set attr on bound method (#539)
0d38538
holg added a commit to holg/playwright-python that referenced this pull request Mar 9, 2021
@holg
Merge commit '0a1c8b7df31d1faa6941eb9e05f772619eddd41b'
2d90a65 
* commit '0a1c8b7df31d1faa6941eb9e05f772619eddd41b':
  chore: Bump twisted to PyPI release (microsoft#543)
  fix: microsoft#518 Update RECORD file during wheel creation (microsoft#525)
  chore: source -> script in add_init_script messages (microsoft#540)
  fix: don't set attr on bound method (microsoft#539)
holg added a commit to holg/playwright-python that referenced this pull request Mar 9, 2021
@holg
[MRG] merged MSPlayWrightPYthon-release1.9 into holg.1.9
d152dcb 
Merge commit '0d4bef9279aff10afd5b6b41c228f800a46ea8ec' into holg-1.9

* commit '0d4bef9279aff10afd5b6b41c228f800a46ea8ec':
  chore: source -> script in add_init_script messages (microsoft#540)
  fix: don't set attr on bound method (microsoft#539)
  chore: roll Playwright to 1.9.1-1614225150000
  chore: roll Playwright to tot (microsoft#522)

# Conflicts:
#	playwright/async_api/_generated.py
#	playwright/sync_api/_generated.py
#	setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

page.on("request", f=func) fails if func is a class method -> AttributeError: 'method' object has no attribute '_pw_api_instance'
2 participants
@pavelfeldman @dgozman