Skip to content

fix(postData): do not require content type when retrieving post data #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021
Merged

fix(postData): do not require content type when retrieving post data #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions playwright/_impl/_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,12 @@ def post_data_json(self) -> Optional[Any]:
if not post_data:
return None
content_type = self.headers["content-type"]
if not content_type:
return None
if content_type == "application/x-www-form-urlencoded":
return dict(parse.parse_qsl(post_data))
return json.loads(post_data)
try:
return json.loads(post_data)
except Exception:
raise Error(f"POST data is not a valid JSON object: {post_data}")

@property
def post_data_buffer(self) -> Optional[bytes]:
Expand Down
38 changes: 38 additions & 0 deletions tests/async/test_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,44 @@ async def test_should_be_undefined_when_there_is_no_post_data(page, server):
assert response.request.post_data_json is None


async def test_should_return_post_data_without_content_type(page, server):
await page.goto(server.EMPTY_PAGE)
async with page.expect_request("**/*") as request_info:
await page.evaluate(
"""({url}) => {
const request = new Request(url, {
method: 'POST',
body: JSON.stringify({ value: 42 }),
});
request.headers.set('content-type', '');
return fetch(request);
}""",
{"url": server.PREFIX + "/title.html"},
)
request = await request_info.value
assert request.post_data_json == {"value": 42}


async def test_should_throw_on_invalid_json_in_post_data(page, server):
await page.goto(server.EMPTY_PAGE)
async with page.expect_request("**/*") as request_info:
await page.evaluate(
"""({url}) => {
const request = new Request(url, {
method: 'POST',
body: '<not a json>',
});
request.headers.set('content-type', '');
return fetch(request);
}""",
{"url": server.PREFIX + "/title.html"},
)
request = await request_info.value
with pytest.raises(Error) as exc_info:
print(request.post_data_json)
assert "POST data is not a valid JSON object: <not a json>" in str(exc_info.value)


async def test_should_work_with_binary_post_data(page, server):
await page.goto(server.EMPTY_PAGE)
server.set_route("/post", lambda req: req.finish())
Expand Down