fix: fix greenlet version for compatibility with pypy #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxschmitt Request to review |
|
Any resource available for that? Or did a user face into that problem? |
|
I myself was trying to use it with pypy, the problem is that pypy comes pre-installed with a greenlet version which was earlier incompatible , with this PR it is fixed. $ docker run --rm -it pypy:3 bashOutput: root@0b966d0b7266:/# pip install playwright
Collecting playwright
Downloading playwright-1.10.0-py3-none-manylinux1_x86_64.whl (20.1 MB)
|████████████████████████████████| 20.1 MB 8.6 MB/s
Collecting greenlet==1.0.0
Downloading greenlet-1.0.0.tar.gz (84 kB)
|████████████████████████████████| 84 kB 1.6 MB/s
Collecting pyee>=8.0.1
Downloading pyee-8.1.0-py2.py3-none-any.whl (12 kB)
Collecting typing-extensions
Downloading typing_extensions-3.7.4.3-py3-none-any.whl (22 kB)
Building wheels for collected packages: greenlet
Building wheel for greenlet (setup.py) ... done
Created wheel for greenlet: filename=greenlet-1.0.0-py3-none-any.whl size=68773 sha256=61949db4252e5819cfc93517a2241d967e9bc8afa0731fad0e5c290936bf7e20
Stored in directory: /root/.cache/pip/wheels/17/3a/a1/cc5eb7126b8a553015e9f04532b943a1d46b8a58c55975e860
Successfully built greenlet
Installing collected packages: typing-extensions, pyee, greenlet, playwright
Attempting uninstall: greenlet
Found existing installation: greenlet 0.4.13
ERROR: Cannot uninstall 'greenlet'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
WARNING: You are using pip version 20.3.4; however, version 21.0.1 is available.
You should consider upgrading via the '/opt/pypy/bin/pypy3 -m pip install --upgrade pip' command. |
mxschmitt
added a commit
that referenced
this pull request
May 11, 2021
This reverts commit 1df5a54. The reason for that is that there was no actual user bug report for it. If we want to add PyPi support in the future, we would also need to add bots to ensure it works over time and reflect the changes in the docs.
mxschmitt
added a commit
that referenced
this pull request
May 11, 2021
This reverts commit 1df5a54. The reason for that is that there was no actual user bug report for it. If we want to add PyPi support in the future, we would also need to add bots to ensure it works over time and reflect the changes in the docs.
|
Since greenlet is built-in to PyPy, the better way to fix this is to specify that the greenlet dependency is CPython specific using PEP 496 environment markers, e.g., gevent writes its dependency as: 'greenlet >= 0.4.17, < 2.0; platform_python_implementation=="CPython"' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.