Skip to content

fix: Rename name to api_name #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2021
Merged

fix: Rename name to api_name #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions playwright/_impl/_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,13 @@ def __init__(
if self._parent:
self._parent._objects[guid] = self

def _wait_for_event_info_before(self, wait_id: str, name: str) -> None:
def _wait_for_event_info_before(self, wait_id: str, api_name: str) -> None:
self._connection._send_message_to_server(
self._guid,
"waitForEventInfo",
{
"info": {
"name": name,
"apiName": api_name,
"waitId": wait_id,
"phase": "before",
"stack": capture_call_stack(),
Expand Down
4 changes: 2 additions & 2 deletions playwright/_impl/_wait_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@


class WaitHelper(Generic[T]):
def __init__(self, channel_owner: ChannelOwner, name: str) -> None:
def __init__(self, channel_owner: ChannelOwner, api_name: str) -> None:
self._result: asyncio.Future = asyncio.Future()
self._wait_id = uuid.uuid4().hex
self._loop = channel_owner._loop
self._pending_tasks: List[Task] = []
self._channel_owner = channel_owner
self._registered_listeners: List[Tuple[EventEmitter, str, Callable]] = []
channel_owner._wait_for_event_info_before(self._wait_id, name)
channel_owner._wait_for_event_info_before(self._wait_id, api_name)

def reject_on_event(
self,
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from auditwheel.wheeltools import InWheel
from wheel.bdist_wheel import bdist_wheel as BDistWheelCommand

driver_version = "1.11.0-next-1618513089000"
driver_version = "1.11.0-next-1618801354000"


def extractall(zip: zipfile.ZipFile, path: str) -> None:
Expand Down