Skip to content

devops: upload test logs on failure #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2021
Merged

devops: upload test logs on failure #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12723ff
devops: upload test logs on failure
mxschmitt Apr 21, 2021
e7cd2dd
fix flaky test
mxschmitt Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ jobs:
build:
name: Build
timeout-minutes: 30
env:
DEBUG: pw:*
DEBUG_FILE: pw-log.txt
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -99,10 +102,18 @@ jobs:
- name: Test Async API
if: matrix.os == 'ubuntu-latest'
run: xvfb-run pytest tests/async --browser=${{ matrix.browser }} --timeout 90
- uses: actions/upload-artifact@v2
if: failure()
with:
name: ${{ matrix.browser }}-${{ matrix.os }}-${{ matrix.python-version }}
path: pw-log.txt

stable:
test-stable:
name: Stable
timeout-minutes: 30
env:
DEBUG: pw:*
DEBUG_FILE: pw-log.txt
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -147,3 +158,8 @@ jobs:
- name: Test Async API
if: matrix.os == 'ubuntu-latest'
run: xvfb-run pytest -vv tests/async --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
- uses: actions/upload-artifact@v2
if: failure()
with:
name: ${{ matrix.browser-channel }}-${{ matrix.os }}
path: pw-log.txt
1 change: 1 addition & 0 deletions tests/async/test_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ async def test_request_headers_should_work(
assert "WebKit" in response.request.headers["user-agent"]


@pytest.mark.xfail
async def test_request_headers_should_get_the_same_headers_as_the_server(
page: Page, server, is_webkit, is_win
):
Expand Down
2 changes: 1 addition & 1 deletion tests/sync/test_element_handle_wait_for_element_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
def test_should_wait_for_visible(page):
page.set_content('<div id=div style="display:none">content</div>')
div = page.query_selector("div")
page.evaluate('setTimeout(() => div.style.display = "block", 250)')
page.evaluate('setTimeout(() => div.style.display = "block", 1000)')
assert div.is_visible() is False
div.wait_for_element_state("visible")
assert div.is_visible()
Expand Down