fix: restrict installation to Ubuntu 18.04 #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
May 6, 2021
| @@ -92,7 +92,7 @@ def run(self) -> None: | |||
| if platform == "mac": | |||
| wheel = "macosx_10_13_x86_64.whl" | |||
| if platform == "linux": | |||
| wheel = "manylinux1_x86_64.whl" | |||
| wheel = "manylinux_2_27_x86_64.whl" | |||
There was a problem hiding this comment.
Note for other reviewers. This means that at least glibc version 2.27 is required which is used in Ubuntu 18.04 (verified).
mxschmitt
approved these changes
May 6, 2021
pavelfeldman
approved these changes
May 7, 2021
mxschmitt
added a commit
that referenced
this pull request
May 12, 2021
This reverts commit 53cf799. On apt based PIP installations only PIP 20.0.2 is shippd, so we can't assume that they have a PIP which is >= 20.3 currently. Maybe in 1-2 years.
mxschmitt
added a commit
that referenced
this pull request
May 12, 2021
This reverts commit 53cf799. On apt based PIP installations only PIP 20.0.2 is shippd, so we can't assume that they have a PIP which is >= 20.3 currently. Maybe in 1-2 years.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PEP 600 this PR restricts installation to Ubuntu 18.04 or higher.