Skip to content

tests: added accessibility tests #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2020
Merged

tests: added accessibility tests #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions playwright/accessibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ def __init__(self, channel: Channel) -> None:
self._channel = channel

async def snapshot(
self, interestingOnly: bool = None, root: ElementHandle = None
self, interestingOnly: bool = True, root: ElementHandle = None
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately there is no undefined in Python. So JSON won't keep it out and will treat it in this case as null -> Client side default parameters will be ignored. So we either have our own "Undefined" which will remove the keys in the serialisation or we duplicate the default values.

) -> Dict:
root = root._channel if root else None
return await self._channel.send(
"snapshot", dict(root=root, interestingOnly=interestingOnly)
"accessibilitySnapshot", dict(root=root, interestingOnly=interestingOnly)
)
Loading