Skip to content

fix: exception when page got closed via browser in persistent context #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2021
Merged

fix: exception when page got closed via browser in persistent context #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion playwright/_impl/_browser_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ def __repr__(self) -> str:
return f"<BrowserContext browser={self.browser}>"

def _on_page(self, page: Page) -> None:
page._set_browser_context(self)
self._pages.append(page)
self.emit(BrowserContext.Events.Page, page)
if page._opener and not page._opener.is_closed():
Expand Down
15 changes: 8 additions & 7 deletions playwright/_impl/_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def __init__(
self, parent: ChannelOwner, type: str, guid: str, initializer: Dict
) -> None:
super().__init__(parent, type, guid, initializer)
self._browser_context: BrowserContext = None # type: ignore
self._browser_context: BrowserContext = parent
self.accessibility = Accessibility(self._channel)
self.keyboard = Keyboard(self._channel)
self.mouse = Mouse(self._channel)
Expand All @@ -126,7 +126,9 @@ def __init__(
self._bindings: Dict[str, Any] = {}
self._routes: List[RouteHandlerEntry] = []
self._owned_context: Optional["BrowserContext"] = None
self._timeout_settings: TimeoutSettings = TimeoutSettings(None)
self._timeout_settings: TimeoutSettings = TimeoutSettings(
self._browser_context._timeout_settings
)
self._video: Optional[Video] = None
self._opener = cast("Page", from_nullable_channel(initializer.get("opener")))

Expand Down Expand Up @@ -217,10 +219,6 @@ def __init__(
def __repr__(self) -> str:
return f"<Page url={self.url!r}>"

def _set_browser_context(self, context: "BrowserContext") -> None:
self._browser_context = context
self._timeout_settings = TimeoutSettings(context._timeout_settings)

def _on_request_failed(
self,
request: Request,
Expand Down Expand Up @@ -271,7 +269,10 @@ def _on_worker(self, worker: "Worker") -> None:

def _on_close(self) -> None:
self._is_closed = True
self._browser_context._pages.remove(self)
if self in self._browser_context._pages:
self._browser_context._pages.remove(self)
if self in self._browser_context._background_pages:
self._browser_context._background_pages.remove(self)
self.emit(Page.Events.Close)

def _on_crash(self) -> None:
Expand Down