Skip to content

fix(websocket): error handling #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021
Merged

fix(websocket): error handling #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion playwright/_impl/_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,8 @@ def __init__(
lambda params: self._on_frame_received(params["opcode"], params["data"]),
)
self._channel.on(
"error", lambda params: self.emit(WebSocket.Events.Error, params["error"])
"socketError",
lambda params: self.emit(WebSocket.Events.Error, params["error"]),
)
self._channel.on("close", lambda params: self._on_close())

Expand Down
21 changes: 21 additions & 0 deletions tests/async/test_websocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import asyncio

import pytest
from flaky import flaky

Expand Down Expand Up @@ -125,3 +127,22 @@ async def test_should_reject_wait_for_event_on_close_and_error(page, ws_server):
async with ws.expect_event("framesent"):
await page.evaluate("window.ws.close()")
assert exc_info.value.message == "Socket closed"


async def test_should_emit_error_event(page, server, browser_name):
future = asyncio.Future()
page.on(
"websocket",
lambda websocket: websocket.on(
"socketerror", lambda err: future.set_result(err)
),
)
await page.evaluate(
"""port => new WebSocket(`ws://localhost:${port}/bogus-ws`)""",
server.PORT,
)
err = await future
if browser_name == "firefox":
assert err == "CLOSE_ABNORMAL"
else:
assert ": 404" in err