Skip to content

enh(sync): event class mapping to sync instances #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mxschmitt
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jul 23, 2020

Pull Request Test Coverage Report for Build 180453756

  • 44 of 45 (97.78%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.6%) to 84.964%

Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/sync_base.py 20 21 95.24%
Totals Coverage Status
Change from base Build 180352118: 3.6%
Covered Lines: 2266
Relevant Lines: 2667

💛 - Coveralls

@mxschmitt mxschmitt force-pushed the feature/sync-dynamic-events branch from 2f81fb2 to 98cca30 Compare July 23, 2020 22:48
@mxschmitt mxschmitt requested a review from pavelfeldman July 23, 2020 23:00
Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sharp!

wait_helper.wait_for_event(sync_base._async_obj, event, predicate)
)

@property
def value(self) -> Any:
if not self._value:
self._value = loop.run_until_complete(self._future)
value = loop.run_until_complete(self._future)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some events with the primitive type values.

@pavelfeldman pavelfeldman merged commit 7f93f70 into microsoft:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants