This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Match linter conditional walk to analysis #1999
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 30, 2019 12:03
This reverts commit 6109ac7.
added 6 commits
March 18, 2020 18:48
|
Is this backwards? Shouldn't we be preventing the analysis from skipping over specific paths if we intend that to only work in stubs? |
|
That is a very good question... So far I just made linter walk same way as analysis so variables are handled identically. Should we limit this to stubs only? I don't know... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1908
Not ideal solution since goto definition still takes to
else(latest) but at least walk matches analysis walk and hence there is no false positive.