fix(BaseViewManager): fixes simple translate transforms #1227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rozele, |
A recent change to BaseViewManager seems to have broken simple translate transforms. It looks like a UWP bug where subsequent matrices set to an existing MatrixTransform are ignored. This change works around that issue. Fixes microsoft#1225
Codecov Report
@@ Coverage Diff @@
## master #1227 +/- ##
======================================
Coverage 32% 32%
======================================
Files 257 257
Lines 18453 18453
Branches 1553 1553
======================================
Hits 5905 5905
Misses 12405 12405
Partials 143 143Continue to review full report at Codecov.
|
rozele
added a commit
that referenced
this pull request
Jul 25, 2017
A recent change to BaseViewManager seems to have broken simple translate transforms. It looks like a UWP bug where subsequent matrices set to an existing MatrixTransform are ignored. This change works around that issue. Fixes #1225
rozele
added a commit
that referenced
this pull request
Jul 25, 2017
A recent change to BaseViewManager seems to have broken simple translate transforms. It looks like a UWP bug where subsequent matrices set to an existing MatrixTransform are ignored. This change works around that issue. Fixes #1225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to BaseViewManager seems to have broken simple translate transforms. It looks like a UWP bug where subsequent matrices set to an existing MatrixTransform are ignored. This change works around that issue.
Fixes #1225