[localization-utilities] Expose parsers directly #3455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove decache dependency Add unit tests
D4N14L
approved these changes
Jun 8, 2022
D4N14L
approved these changes
Jun 8, 2022
6 tasks
apostolisms
approved these changes
Jun 13, 2022
iclanton
reviewed
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the dependency on
decachein favor of leveragingvm.runInNewContextto run each pseudolocalizer in its own context.Exposes the resjson and loc.json parsers directly, in addition to the current code path through a highly opinionated dispatcher. The motivation being to allow webpack loaders to use the parsers on arbitrary content or on output of other custom loaders.
How it was tested
New unit tests
Usage in upcoming webpack 5 localization plugin