-
Notifications
You must be signed in to change notification settings - Fork 641
Localization Plugin webpack 5 #3459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmichon-msft
merged 3 commits into
microsoft:main
from
dmichon-msft:localization-plugin-5
Jun 23, 2022
Merged
Localization Plugin webpack 5 #3459
dmichon-msft
merged 3 commits into
microsoft:main
from
dmichon-msft:localization-plugin-5
Jun 23, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please investigate #3460 first. It seems we need to deprecate the published |
dmichon-msft
commented
Jun 10, 2022
9019417
to
46f0872
Compare
iclanton
reviewed
Jun 20, 2022
236de14
to
fe42caf
Compare
iclanton
reviewed
Jun 22, 2022
iclanton
reviewed
Jun 22, 2022
iclanton
reviewed
Jun 22, 2022
iclanton
reviewed
Jun 22, 2022
iclanton
reviewed
Jun 22, 2022
webpack/localization-plugin-5/src/loaders/IResxLoaderOptions.ts
Outdated
Show resolved
Hide resolved
iclanton
reviewed
Jun 22, 2022
iclanton
reviewed
Jun 22, 2022
iclanton
reviewed
Jun 22, 2022
iclanton
reviewed
Jun 22, 2022
iclanton
reviewed
Jun 22, 2022
iclanton
reviewed
Jun 22, 2022
iclanton
reviewed
Jun 22, 2022
webpack/localization-plugin-5/src/test/LocalizedAsyncDynamic.test.ts
Outdated
Show resolved
Hide resolved
webpack/localization-plugin-5/src/test/LocalizedAsyncDynamic.test.ts
Outdated
Show resolved
Hide resolved
webpack/localization-plugin-5/src/test/__snapshots__/LocalizedAsyncDynamic.test.ts.snap
Show resolved
Hide resolved
iclanton
reviewed
Jun 22, 2022
webpack/localization-plugin-5/src/test/__snapshots__/LocalizedRuntime.test.ts.snap
Show resolved
Hide resolved
iclanton
reviewed
Jun 22, 2022
webpack/localization-plugin-5/src/test/__snapshots__/LocalizedRuntime.test.ts.snap
Outdated
Show resolved
Hide resolved
iclanton
reviewed
Jun 22, 2022
webpack/localization-plugin-5/src/test/MixedAsyncDynamic.test.ts
Outdated
Show resolved
Hide resolved
70e5f31
to
b19993d
Compare
iclanton
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a webpack 5 compatible version of
@rushstack/localization-plugin
, intended to be published as major version 5 of the same name.Depends on #3455 for necessary changes to
@rushstack/localization-utilities
.Details
The interface for the webpack 5 plugin is a bit more generic and less opinionated than the webpack 4 version, and requires developers to install the loaders manually (as they would for, e.g. mini-css-extract-plugin). The loaders support
json
orjavascript/esm
output for flexibility.The plugin adds support for the
[locale]
token in theoutput.chunkFilename
andoutput.filename
webpack configuration properties.How it was tested
Unit test coverage of:
none