[heft-swc] Fix source maps #5220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the source maps emitted by
heft-isolated-typescript-transpile-pluginwere not discoverable by tools.Details
The
//# sourceMappingURL=...comment was not conformant to the spec for such comments.Also fixed parsing of the
outDirschema field so that it allows standard relative paths (e.g. "./lib" or "lib" and does not require paths to start with a slash.How it was tested
Added a build test project and ran it under debugger, verifying that VS Code could discover the breakpoints in the original ExampleTest.test.ts file.
Impacted documentation
None.