Allow user tests to specify branch #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update users tests per microsoft/TypeScript#48128
|
@weswigham you might be interested in this. The test updates mirror the ones from #48128, and we should eventually shut those down, I think. Separately, the selection of test projects is 5 years old, and could use some updating as well. |
|
Well, the tests failed about as well as can be expected. I'm going to merge it and try it with an existing test TS PR. |
|
Yep, seems fine. |
|
Re: tests in TS itself. This repo only tracks changes between main and a PR, meanwhile the TS repo tests track changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update users tests per microsoft/TypeScript#48128