Fix parsing of commandline string array #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the parsing of command-line string array options like --typeRoots in tests by correcting the type conversion from []string to []any that the parseCompilerOptions function expects.
- Fixed the list type parsing functions to return
[]anyinstead of[]string - Updated file path handling logic to properly check if an option's elements have the
IsFilePathproperty - Modified test utilities to handle the new array type structure for harness options
Reviewed Changes
Copilot reviewed 143 out of 143 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/tsoptions/commandlineparser.go | Changed return type of list parsing functions from []string to []any and improved element type checking |
| internal/tsoptions/parsinghelpers.go | Fixed conditional logic to check both list type and element file path properties |
| internal/testutil/harnessutil/harnessutil.go | Updated option parsing to handle file paths in list options and modified harness option parsing |
| internal/incremental/snapshottobuildinfo.go | Updated file path checking logic to match the new structure |
| internal/fourslash/fourslash.go | Added missing currentDirectory parameter to function call |
jakebailey
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that we were not handling parsing of say --typeRoots in tests which was because of making
[]stringinstead of[]anywhich is whatparseCompilerOptionsexpects