Encode only libFile name instead of path to it in buildInfo #1567
+349
−320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies how TypeScript library files are referenced in build info (tsbuildinfo) files by encoding only the library file name instead of its full path. This change reduces the file size of build info files and makes them more portable across different environments.
Key changes:
- Library file names in build info are shortened from full paths like
"../../../../tslibs/TS/Lib/lib.esnext.full.d.ts"to just filenames like"lib.esnext.full.d.ts" - Build info file sizes are correspondingly reduced by 20-26 bytes per file
jakebailey
reviewed
Aug 12, 2025
| //// [/home/src/workspaces/project/tsconfig.tsbuildinfo.readable.baseline.txt] *new* | ||
| { | ||
| "version": "FakeTSVersion", | ||
| "fileNames": [ | ||
| "../../tslibs/TS/Lib/lib.d.ts", | ||
| "lib.d.ts", |
There was a problem hiding this comment.
Should there be some special naming moniker to indicate that these paths are sanitized in some way? Or is it the case that fileNames is always relative paths and so this naming is okay?
There was a problem hiding this comment.
Yes the fileNames are relative to buildInfo so should be ok imo .. if need arises we can probably add some special character in the beginning to identify them
jakebailey
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1548