Skip to content

parse enums correctly when converting to compilerOptions struct #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 25, 2025
Merged

parse enums correctly when converting to compilerOptions struct #383

merged 5 commits into from
Feb 25, 2025

Conversation

iisaduan
Copy link
Member

  • fixes harness/commandline: --lib ignored, either not parsed or later skipped #312
    • adds a set to look up lib file names, in case the lib name has already been converted.
    • adds a new function instead of using old tsconfigParsing functions, so we don't perform redundant error checking and enum conversions
    • ideally, any object that is entered into a compilerOptions object should always be checked for validity before it is added to the object, so hopefully we can remove the check in Program creation in the future
  • reverts some parsing abstractions that happened in add watch options #276

@iisaduan iisaduan merged commit e32aa05 into microsoft:main Feb 25, 2025
16 checks passed
@iisaduan iisaduan deleted the enum-options branch February 25, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@gabritto gabritto Awaiting requested review from gabritto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

harness/commandline: --lib ignored, either not parsed or later skipped
2 participants
@iisaduan @jakebailey