Reparse @import as synthetic type-only import declaration
#831
+154
−755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is slightly stricter than Strada's treatment because Corsa now treats the synthetic node *exactly* as a type-only declaration.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new syntax node (KindJSImportDeclaration) to support the re-parsing of @import annotations as synthetic type‑only import declarations. The updates ensure that all relevant components—including transformers, printers, checkers, AST utilities, and unit tests—properly recognize and handle the new Kind alongside the traditional import declaration.
- Extended switch-case statements and error handling in multiple modules to include KindJSImportDeclaration.
- Updated AST creation methods and reparse logic to correctly mark synthetic jsimport declarations as type‑only.
Reviewed Changes
Copilot reviewed 52 out of 53 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/baselines/reference/submodule/conformance/importTag15(module=esnext).errors.txt | Adjusted error output to account for the additional type‑only import errors. |
| testdata/baselines/reference/submodule/conformance/importTag15(module=es2015).errors.txt | Updated error messages and counts for invalid use of import attributes. |
| internal/transformers/typeeraser.go | Added KindJSImportDeclaration in the type eraser transformer to ensure proper traversal. |
| internal/transformers/importelision.go | Extended import elision logic to handle synthetic jsimport declarations. |
| internal/transformers/externalmoduleinfo.go | Modified external module info collection to include KindJSImportDeclaration. |
| internal/transformers/esnext.go | Updated transformer switch to recognize KindJSImportDeclaration. |
| internal/transformers/esmodule.go | Added a case to handle KindJSImportDeclaration during ES module transformation. |
| internal/transformers/commonjsmodule.go | Added handling for KindJSImportDeclaration as a no‑op, aligning with CommonJS semantics. |
| internal/printer/printer.go | Extended the printer to generate nodes for KindJSImportDeclaration. |
| internal/printer/namegenerator.go | Modified name generation logic to include KindJSImportDeclaration along with existing types. |
| internal/parser/reparser.go | Implemented reparse logic for @import JSDoc tags to create synthetic jsimport declarations marked as type‑only. |
| internal/ls/utilities.go | Updated language service utilities to recognize KindJSImportDeclaration in import specifier resolution. |
| internal/checker/grammarchecks.go | Adjusted grammar checks to include KindJSImportDeclaration when validating ambient import modifiers. |
| internal/checker/checker.go | Integrated KindJSImportDeclaration in multiple checking routines for import declarations. |
| internal/ast/utilities.go | Updated various AST utility functions to support KindJSImportDeclaration in their logic. |
| internal/ast/kind_stringer_generated.go | Revised generated string mappings to include KindJSImportDeclaration. |
| internal/ast/kind.go | Declared the new constant KindJSImportDeclaration. |
| internal/ast/ast.go | Updated factory methods for creating import declarations to allow creation of KindJSImportDeclaration. |
Files not reviewed (1)
- testdata/baselines/reference/submodule/conformance/importTag1.errors.txt: Language not supported
sandersn
commented
Apr 28, 2025
testdata/baselines/reference/submoduleAccepted/conformance/importTag16.types.diff
Show resolved
Hide resolved
sandersn
commented
Apr 28, 2025
testdata/baselines/reference/submoduleAccepted/conformance/importTag17.errors.txt.diff
Show resolved
Hide resolved
No longer used; everything now uses JSImportDeclaration.
|
@a-tarasyuk you wrote the original implementation of |
rbuckton
requested changes
Apr 28, 2025
gabrielluizsf
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is slightly stricter than Strada's treatment because Corsa now treats the synthetic node exactly as a type-only declaration.