[LSP] fix crash on inferred project JS files #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash on inferred project JS files by properly recognizing JavaScript files in inferred projects.
- Added a new test case for JS files in inferred projects.
- Updated the compiler options in the inferred project creation to enable AllowJs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/project/service_test.go | Added a JS project test verifying that the project correctly handles JS files. |
| internal/project/service.go | Updated the default inferred project creation to enable JS file support. |
| } | ||
| service, _ := projecttestutil.Setup(jsFiles) | ||
| service.OpenFile("/home/projects/TS/p1/index.js", jsFiles["/home/projects/TS/p1/index.js"], core.ScriptKindJS, "") | ||
| assert.Equal(t, len(service.Projects()), 1) |
There was a problem hiding this comment.
The expected and actual arguments in assert.Equal appear to be reversed. Consider changing the order to assert.Equal(t, 1, len(service.Projects())) to follow testify's convention and improve error clarity.
Suggested change
| assert.Equal(t, len(service.Projects()), 1) | |
| assert.Equal(t, 1, len(service.Projects())) |
Copilot uses AI. Check for mistakes.
sheetalkamat
reviewed
May 6, 2025
sheetalkamat
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.