Fix typesVersions #848
Merged
Fix typesVersions #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues related to typesVersions handling by updating baseline error outputs and correcting the logic in package JSON and module resolution code.
- Updated baseline errors to reflect the reduced error count in module resolution tests.
- Reversed a semver condition and updated the assignment of the paths variable for clarity in cache.go.
- Modified the package info handling in resolver.go to unconditionally fetch version paths when package info exists.
Reviewed Changes
Copilot reviewed 19 out of 36 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| testdata/baselines/reference/submodule/conformance/nodeModulesExportsBlocksTypesVersions(module=nodenext).errors.txt | Updated baseline error counts and removed outdated error entries. |
| internal/packagejson/cache.go | Fixed semver condition and improved assignment logic for paths variable. |
| internal/module/resolver.go | Changed the logic to always get versionPaths if the package exists, then conditionally process candidate matching. |
Files not reviewed (17)
- testdata/baselines/reference/submodule/conformance/nodeModulesExportsBlocksTypesVersions(module=node16).errors.txt: Language not supported
- testdata/baselines/reference/submodule/conformance/nodeModulesExportsBlocksTypesVersions(module=node16).errors.txt.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/nodeModulesExportsBlocksTypesVersions(module=nodenext).errors.txt.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersions.ambientModules.errors.txt: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersions.ambientModules.errors.txt.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersions.ambientModules.symbols: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersions.ambientModules.symbols.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersions.ambientModules.types: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersions.ambientModules.types.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersions.multiFile.errors.txt: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersions.multiFile.errors.txt.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersions.multiFile.symbols: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersions.multiFile.symbols.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersions.multiFile.types: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersions.multiFile.types.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersionsDeclarationEmit.ambient.symbols: Language not supported
- testdata/baselines/reference/submodule/conformance/typesVersionsDeclarationEmit.ambient.symbols.diff: Language not supported
Comments suppressed due to low confidence (3)
internal/packagejson/cache.go:42
- Reversing the condition to 'if !ok' now correctly triggers the error trace for invalid semver ranges; please confirm that this change is intended.
if !ok {
internal/packagejson/cache.go:99
- [nitpick] Using the local 'paths' variable for updating rather than directly modifying v.paths improves clarity; please verify that the subsequent reassignment to v.paths aligns with the expected logic.
paths.Set(key, slice)
internal/module/resolver.go:1261
- [nitpick] Fetching versionPaths unconditionally when packageInfo exists may change the resolution behavior; please verify that this modification aligns with the intended logic for module resolution.
versionPaths = packageInfo.Contents.GetVersionPaths(r.getTraceFunc())
DanielRosenwasser
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #846