Improve the missing CompilerOptions check #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mucks with the real code a bit, but it works better and is simpler. See microsoft#839 microsoft#842
jakebailey
reviewed
May 8, 2025
gabrielluizsf
approved these changes
May 8, 2025
jakebailey
approved these changes
May 8, 2025
|
@gabrielluizsf FYI your reviews don't actually have any effect since you don't have merge perms on this repo; if anything they just spam us with notifications we have to ignore. I'd prefer if you didn't just approve every PR on this repo. |
I apologize for any inconvenience caused. My intention was simply to contribute constructively, but I understand that it may have generated unnecessary notifications. I appreciate the feedback and will be more mindful going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mucks with the real code a bit, but it works better and is simpler.
@jakebailey FYI, and I swear I'm done bugging you 😝
See #839 #842