Don't error on --incremental, just run normally #908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the early exit and error for the "--incremental" flag, allowing the compilation to proceed normally.
- Test baseline updated to expect a successful exit status (0) instead of an error (7)
- Removed checks for incremental compilation in tsc.go to bypass the not-implemented status
- Removed the redundant ExitStatusNotImplementedIncremental constant from system.go
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| testdata/baselines/reference/tsc/noEmit/when-project-has-strict-true.js | Updated expected exit status to reflect normal compilation behavior. |
| internal/execute/tsc.go | Removed incremental compilation branches to allow normal compilation flow. |
| internal/execute/system.go | Removed the unused incremental compilation exit status constant. |
andrewbranch
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns off the early exit and error for
--incremental; I think it's fine to just let compilation proceed in this case.Fixes #906